Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove version match on api #2038

Merged
merged 10 commits into from
Aug 6, 2021
Merged

feat: remove version match on api #2038

merged 10 commits into from
Aug 6, 2021

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Aug 5, 2021 •
edited
Loading

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2005

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Aug 5, 2021 •
edited
Loading

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 334f1be

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/610c18af69cc8e00075f9966

😎 Browse the preview: https://deploy-preview-2038--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021 •
edited
Loading

Codecov Report

Merging #2038 (bb090d7) into master (005fd90) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

❗ Current head bb090d7 differs from pull request most recent head 334f1be. Consider uploading reports for the commit 334f1be to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
- Coverage   63.97%   63.57%   -0.40%     
==========================================
  Files         121      181      +60     
  Lines        3156     6935    +3779     
  Branches      753      753              
==========================================
+ Hits         2019     4409    +2390     
- Misses       1137     2180    +1043     
- Partials        0      346     +346
Flag Coverage Δ
backend-e2e-test 47.07% <100.00%> (?)
backend-e2e-test-ginkgo 48.74% <100.00%> (?)
frontend-e2e-test 64.03% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/utils/utils.go 71.00% <ø> (ø)
api/internal/handler/tool/tool.go 100.00% <100.00%> (ø)
api/internal/utils/version.go 100.00% <0.00%> (ø)
api/internal/handler/schema/schema.go 100.00% <0.00%> (ø)
api/internal/utils/closer.go 33.33% <0.00%> (ø)
api/internal/handler/schema/plugin.go 100.00% <0.00%> (ø)
api/cmd/root.go 80.00% <0.00%> (ø)
api/internal/utils/json_patch.go 50.00% <0.00%> (ø)
api/internal/core/server/store.go 25.00% <0.00%> (ø)
.../internal/handler/authentication/authentication.go 90.47% <0.00%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005fd90...334f1be. Read the comment docs.

@juzhiyuan juzhiyuan requested review from starsz and nic-chen August 6, 2021 02:33
@juzhiyuan juzhiyuan requested a review from Jaycean August 6, 2021 03:52
@juzhiyuan juzhiyuan merged commit c9456af into apache:master Aug 6, 2021
@okaybase okaybase deleted the remove-version-match branch August 6, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-chen nic-chen nic-chen approved these changes

@liuxiran liuxiran liuxiran approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@starsz starsz Awaiting requested review from starsz

@Jaycean Jaycean Awaiting requested review from Jaycean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove version match logics from both Web and Backend
5 participants
@okaybase @codecov-commenter @juzhiyuan @liuxiran @nic-chen